Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #7052, hmr style tag no support in html #7136

Merged
merged 1 commit into from Mar 1, 2022
Merged

Conversation

patak-dev
Copy link
Member

Fix #7124

Description

See #7124, @poyoho is working on this PR to re-merge it in 2.9. The issue may be on @IanVS's vite storybook builder side, but it is safer to introduce this change in a minor.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev added the p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) label Mar 1, 2022
@patak-dev patak-dev merged commit 5c116ec into main Mar 1, 2022
@patak-dev patak-dev deleted the fix/revert-7052 branch March 1, 2022 19:45
sinoon pushed a commit to sinoon/vite that referenced this pull request Mar 2, 2022
poyoho added a commit to poyoho/vite that referenced this pull request Mar 11, 2022
@usercao
Copy link

usercao commented Apr 18, 2022

@patak-dev This problem reappears in version 2.9.5.

@poyoho
Copy link
Member

poyoho commented Apr 18, 2022

can you show this issues link ?

@usercao
Copy link

usercao commented Apr 18, 2022

can you show this issues link ?

#6032 #7124 Same question.

@poyoho
Copy link
Member

poyoho commented Apr 18, 2022

but there were closed, it only affects server mode. Do you ask for this #7786?

@usercao
Copy link

usercao commented Apr 18, 2022

I'm not sure, but as long as the <style></style> is added to the entry page index.html, this problem will recur.Error reporting is the same as 6032.

@patak-dev
Copy link
Member Author

@usercao please open a new issue with a minimal reprduction. Thanks!

@usercao usercao mentioned this pull request Apr 29, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.8.5] Invalid script being added to html
3 participants