Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgraded vite #2678

Merged
merged 6 commits into from Mar 2, 2022
Merged

fix: upgraded vite #2678

merged 6 commits into from Mar 2, 2022

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Feb 28, 2022

Changes

Upgraded Vite to v2.8.6 (fixes #2639 via vitejs/vite#7093)

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2022

🦋 Changeset detected

Latest commit: 3624fc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 28, 2022
@FredKSchott
Copy link
Member

oh no, vite errors! cc @natemoo-re

@JuanM04
Copy link
Contributor Author

JuanM04 commented Feb 28, 2022

@FredKSchott maybe it's related to this? vitejs/vite#7031

@FredKSchott
Copy link
Member

@JuanM04 🥁 🥁 🥁 🥁

@JuanM04
Copy link
Contributor Author

JuanM04 commented Mar 1, 2022

@FredKSchott Turns out the change that broke the test was reverted, so Vite v2.8.6 works fine. I'm hoping that Windows plays nice 🙃

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@natemoo-re natemoo-re merged commit caf9135 into withastro:main Mar 2, 2022
@JuanM04 JuanM04 deleted the vite-upgrade branch March 2, 2022 21:56
@github-actions github-actions bot mentioned this pull request Mar 2, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* fix: upgraded vite

* chore: changeset

* Upgraded to vite v2.8.6

* Updated changeset

Co-authored-by: Fred K. Schott <fkschott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: vite:import-analysis error with vercel dev
3 participants