Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing types for es-module-lexer (fixes #8349) #8352

Merged
merged 2 commits into from May 27, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented May 27, 2022

Description

  • Add check-dist-type
    • I'm not sure if this is an ideal way to check this
    • Alternative to this way, npm i --production can be used. I am not sure if it works as I expect. I will try it later. I found it need much more work than this one.
  • Inilne es-module-lexer type

fixes #8349

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

exports: ReadonlyArray<string>,
facade: boolean
]
export type ExportsData = EsModuleLexerParseReturnType & {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These needs to be exported because it is included in the return type of vite.optimize.
But are these needs to be exported? (I didnt check closely yet)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also export them to be safe, and then we remove them in another PR if they are unneeded.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check it and create a new PR if I felt it won't be needed 👍

@sapphi-red sapphi-red marked this pull request as ready for review May 27, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.0.0-alpha.5: missing types for es-module-lexer
2 participants