Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export missing picomatch type def from optimizer (fixes #10656) #10672

Closed
wants to merge 1 commit into from

Conversation

timacdonald
Copy link
Contributor

@timacdonald timacdonald commented Oct 27, 2022

Description

Fixes: #10656 which is also currently failing the Laravel and Svelte Kit builds.

This PR attempts to fix an issue with a missing type definition for Picomatch.

This approach was an attempt to duplicate previous ways of handling this, such as #8352

馃毃 I have no idea what I'm doing and this could be completely incorrect.

Additional context

N/A

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

I think this is covered by the eco-system CI tests...

  • Ideally, include relevant tests that fail without this PR but pass with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite 3.2.0 type definitions depend on picomatch
1 participant