Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): trim trailing comma worker constructor option #10213

Closed
wants to merge 2 commits into from

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Sep 23, 2022

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy
Copy link
Member

bluwy commented Sep 23, 2022

I also sent a fix at #10211 🙈

@ydcjeff ydcjeff changed the title fix: trim trailing comma worker constructor option fix(worker): trim trailing comma worker constructor option Sep 23, 2022
@ydcjeff
Copy link
Contributor Author

ydcjeff commented Sep 23, 2022

I also sent a fix at #10211 🙈

Yea, I saw it after I opened the PR.

@patak-dev
Copy link
Member

Merged #10211, thanks @ydcjeff for digging into this one too!

@patak-dev patak-dev closed this Sep 23, 2022
@ydcjeff ydcjeff deleted the gh-10206 branch September 24, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing comma in new Worker() breaks options parsing
3 participants