Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update type init #10251

Merged
merged 1 commit into from Sep 26, 2022
Merged

chore: update type init #10251

merged 1 commit into from Sep 26, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Sep 26, 2022

Description

use other ts syntax to resolve init issues #9569 (comment)

Additional context

don't need to init array to kept the dts run well


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@poyoho poyoho requested a review from bluwy September 26, 2022 09:40
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Didn't know this syntax exists.

@bluwy bluwy changed the title fix: typo chore: update type init Sep 26, 2022
@bluwy bluwy merged commit ed40a65 into vitejs:main Sep 26, 2022
@poyoho poyoho deleted the chore/typo branch September 26, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants