Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not externalize monorepo modules, revert #9140 #10321

Closed
wants to merge 1 commit into from

Conversation

antfu
Copy link
Member

@antfu antfu commented Oct 3, 2022

Description

Revert #9140, since it introduced more serious breakage #9202, I think it's better to revert it for now (as SvelteKit no longer needs it either). An alternative solution is under exploring in #10254 for the future.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 3, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
iles ✅ success
ladle ❌ failure
laravel ❌ failure
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
storybook ❌ failure
svelte ✅ success
vite-plugin-ssr ❌ failure
vite-setup-catalogue ✅ success
vitepress ❌ failure
vitest ❌ failure
windicss ✅ success

@patak-dev
Copy link
Member

@antfu would it be ok to release this as part of 3.2? We can release a beta today/tomorrow and release stable after ViteConf. Or should we also port it to 3.0 and 3.1? cc @bluwy

@patak-dev patak-dev added the p3-significant High priority enhancement (priority) label Oct 3, 2022
@antfu
Copy link
Member Author

antfu commented Oct 3, 2022

I would prefer to backport it to 3.1

@antfu
Copy link
Member Author

antfu commented Oct 3, 2022

fixed by #10254

@antfu antfu closed this Oct 3, 2022
@sapphi-red sapphi-red deleted the fix/revert-9140 branch October 10, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-significant High priority enhancement (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants