Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(env): support dotenv-expand to contains process env #10370

Merged
merged 11 commits into from Nov 8, 2022
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite/package.json
Expand Up @@ -89,7 +89,7 @@
"debug": "^4.3.4",
"dep-types": "link:./src/types",
"dotenv": "^14.3.2",
"dotenv-expand": "^5.1.0",
"dotenv-expand": "^9.0.0",
"es-module-lexer": "^1.1.0",
"estree-walker": "^3.0.1",
"etag": "^1.8.1",
Expand Down
15 changes: 11 additions & 4 deletions packages/vite/src/node/env.ts
@@ -1,6 +1,6 @@
import fs from 'node:fs'
import dotenv from 'dotenv'
import dotenvExpand from 'dotenv-expand'
import { expand } from 'dotenv-expand'
import { arraify, lookupFile } from './utils'
import type { UserConfig } from './config'

Expand Down Expand Up @@ -40,11 +40,18 @@ export function loadEnv(
)

// let environment variables use each other
dotenvExpand({
parsed,
const expandParsed = expand({
parsed: {
...(process.env as any),
...parsed
},
// prevent process.env mutation
ignoreProcessEnv: true
} as any)
}).parsed!

Object.keys(parsed).forEach((key) => {
parsed[key] = expandParsed[key]
})
sapphi-red marked this conversation as resolved.
Show resolved Hide resolved

// only keys that start with prefix are exposed to client
for (const [key, value] of Object.entries(parsed)) {
Expand Down
3 changes: 2 additions & 1 deletion playground/env/.env
@@ -1,4 +1,5 @@
VITE_CUSTOM_ENV_VARIABLE=1
CUSTOM_PREFIX_ENV_VARIABLE=1
VITE_EFFECTIVE_MODE_FILE_NAME=.env
VITE_BOOL=true
VITE_BOOL=true
VITE_EXPAND=$EXPAND
4 changes: 4 additions & 0 deletions playground/env/__tests__/env.spec.ts
Expand Up @@ -45,6 +45,10 @@ test('NODE_ENV', async () => {
expect(await page.textContent('.node-env')).toBe(process.env.NODE_ENV)
})

test('expand', async () => {
expect(await page.textContent('.expand')).toBe('expand')
})

test('env object', async () => {
const envText = await page.textContent('.env-object')
expect(JSON.parse(envText)).toMatchObject({
Expand Down
2 changes: 2 additions & 0 deletions playground/env/index.html
Expand Up @@ -14,6 +14,7 @@ <h1>Environment Variables</h1>
<p>import.meta.env.VITE_INLINE: <code class="inline"></code></p>
<p>typeof import.meta.env.VITE_BOOL: <code class="bool"></code></p>
<p>process.env.NODE_ENV: <code class="node-env"></code></p>
<p>process.env.VITE_EXPAND: <code class="expand"></code></p>
bluwy marked this conversation as resolved.
Show resolved Hide resolved
<p>import.meta.env: <span class="pre env-object"></span></p>
<p>import.meta.url: <span class="pre url"></span></p>

Expand All @@ -29,6 +30,7 @@ <h1>Environment Variables</h1>
text('.bool', typeof import.meta.env.VITE_BOOL)
text('.node-env', process.env.NODE_ENV)
text('.env-object', JSON.stringify(import.meta.env, null, 2))
text('.expand', import.meta.env.VITE_EXPAND)

function text(el, text) {
document.querySelector(el).textContent = text
Expand Down
2 changes: 2 additions & 0 deletions playground/env/vite.config.js
@@ -1,5 +1,7 @@
const { defineConfig } = require('vite')

process.env.EXPAND = 'expand'

module.exports = defineConfig({
base: '/env/',
envPrefix: ['VITE_', 'CUSTOM_PREFIX_'],
Expand Down