Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove console.log #10704

Merged
merged 1 commit into from Oct 29, 2022
Merged

test: remove console.log #10704

merged 1 commit into from Oct 29, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 29, 2022 •
edited

Description

I guess this wasn't expected to be included. 馃
https://github.com/vitejs/vite/actions/runs/3350758366/jobs/5551774699#step:12:18

refs #10333

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Oct 29, 2022
@sapphi-red sapphi-red requested a review from bluwy October 29, 2022 10:47
@patak-dev patak-dev enabled auto-merge (squash) October 29, 2022 10:49
@patak-dev patak-dev merged commit cab9f19 into vitejs:main Oct 29, 2022
@sapphi-red sapphi-red deleted the test/remove-console-log branch October 29, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy Awaiting requested review from bluwy

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sapphi-red @patak-dev