Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add @types/node as an optional peer dependency #10757

Merged
merged 1 commit into from Nov 4, 2022

Commits on Nov 2, 2022

  1. fix: add @types/node as an optional peer dependency

    The built bundle of Vite starts with a reference to `node` types:
    https://unpkg.com/browse/vite@3.2.2/dist/node/index.d.ts
    
    This means those who depend on Vite type definitions should install
    `@types/node` in their projects to successfully do type-checking.
    In that sense, `@types/node` is an optional peer dependency of Vite.
    
    After this being fixed, we should revert vitejs/vite-ecosystem-ci#85 because not explicitly depending on
    `@types/node` *should* be erroneous. The ecosystem CI shouldn't cover
    that error for downstream packages.
    sodatea committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    2a7c6ac View commit details
    Browse the repository at this point in the history