fix: Add fallback for spa in preview. #10944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc
force-pushed
the
clay/preview-spa-fallback
branch
from
30f4e79
to
38f919a
Compare
bluwy
reviewed
Nov 18, 2022
|
We would need to update the failing tests too. Looks like 2 we're incorrectly checking this for the SPA case. |
I took some stabs at updating the tests. Currently it defaults to being an appType of |
fc
force-pushed
the
clay/preview-spa-fallback
branch
from
18901c5
to
a56c139
Compare
fc
force-pushed
the
clay/preview-spa-fallback
branch
from
7e03965
to
5136f11
Compare
fc
commented
Nov 23, 2022
| @@ -70,6 +71,7 @@ describe.runIf(isServe)('serve', () => { | |||
| }) | |||
|
|
|||
| test('CSS dependencies are tracked for HMR', async () => { | |||
| await startDefaultServe('spa') | |||
There was a problem hiding this comment.
I'm not 100% sure why this is necessary.
fc
commented
Nov 23, 2022
Comment on lines
+81
to
+87
| 'index: 404', | ||
| 'index-legacy: 404', | ||
| 'chunk-async: 404', | ||
| 'chunk-async-legacy: 404', | ||
| 'immutable-chunk: 404', | ||
| 'immutable-chunk-legacy: 404', | ||
| 'polyfills-legacy: 404' |
There was a problem hiding this comment.
Not sure why this would be 404s?
|
I don't understand why my tests fail on Linux but not on macOS |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #10925
Resolves this issue - Routing broken for preview with react-router-dom in 4.0.0-alpha.2
When
config.appType === 'spa'is true then then the single option of sirv is enabled. Docs - "When true, the directory's index page (default index.html) will be sent if the request asset does not exist."So, I think we would want to mimic the behavior of sirv for spa apps and to fallback to routing to index.html when shouldServe is false.
Questions - is there an appropriate way to handle the tests for this? It's blowing up.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).