Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove vue plugin from optimize-deps playground #11452

Conversation

sapphi-red
Copy link
Member

Description

#11175

This test seems to be added by 1ea0168 and was intended to test whether the plugins will run on dep-optimization.
But since dep-optimization now uses esbuild instead of rollup, this test was outdated.
I changed this test's name to describe the actual thing we are now testing.
IIUC this test is now testing this part.

// externalize assets and commonly known non-js file types
// See #8459 for more details about this require-import conversion
build.onResolve(
{
filter: new RegExp(
`\\.(` + allExternalTypes.join('|') + `)(\\?.*)?$`,
),
},

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Dec 21, 2022
@patak-dev patak-dev merged commit 8196a5f into vitejs:main Dec 21, 2022
@sapphi-red sapphi-red deleted the test/remove-vue-plugin-from-optimize-deps-playground branch December 21, 2022 06:07
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants