Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): enhance error message for missing preprocessor dependency #11485

Merged
merged 7 commits into from Jul 31, 2023
Merged

fix(css): enhance error message for missing preprocessor dependency #11485

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7f3135b
chore(vite): enhance error message when can't find css preprocessor d…
EastSun5566 Dec 25, 2022
f3f55c8
chore(css): use the `lang` variable directly as the package name
EastSun5566 Dec 26, 2022
c925c9d
chore(css): add package manager from user land
EastSun5566 Dec 26, 2022
cbff750
Merge branch 'vitejs:main' into chore/enhance-error-message
EastSun5566 Jun 2, 2023
efe909a
Merge branch 'main' into chore/enhance-error-message
EastSun5566 Jul 28, 2023
d6728f0
feat: add `getPackageManagerCommand` util
EastSun5566 Jul 28, 2023
c55ae7b
feat: should handle default case
EastSun5566 Jul 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/vite/src/node/plugins/css.ts
View file
Open in desktop
Expand Up @@ -1504,8 +1504,16 @@ function loadPreprocessor(
return (loadedPreprocessors[lang] = _require(resolved))
} catch (e) {
if (e.code === 'MODULE_NOT_FOUND') {
const preprocessorPackage = {
[PreprocessLang.scss]: 'sass',
[PreprocessLang.sass]: 'sass',
[PreprocessLang.less]: 'less',
[PreprocessLang.styl]: 'stylus',
[PreprocessLang.stylus]: 'stylus',
[PostCssDialectLang.sss]: 'sugarss',
}
throw new Error(
`Preprocessor dependency "${lang}" not found. Did you install it?`,
`Preprocessor dependency "${lang}" not found. Did you install it? Try \`npm i -D ${preprocessorPackage[lang]}\`.`,
EastSun5566 marked this conversation as resolved.
Show resolved Hide resolved
)
} else {
const message = new Error(
Expand Down