Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check whether to build before preview #11570

Closed
wants to merge 1 commit into from
Closed

feat: check whether to build before preview #11570

wants to merge 1 commit into from

Conversation

chenfan0
Copy link
Contributor

@chenfan0 chenfan0 commented Jan 3, 2023

Description

I think when we open the preview mode, if the build operation has not been performed, an error should be thrown to remind the developer instead of continuing to open the preview service. like below

image

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red
Copy link
Member

This was previously attempted by #10564 but was reverted because it caused a breaking change (#10564 (comment)).

@patak-dev
Copy link
Member

Yes, thanks for the PR @chenfan0, but given how other tools are using Vite, we can't add this for the moment. We could in a major by introducing an option to disable the error but I feel that the complexity of doing so isn't worthy it.

@patak-dev patak-dev closed this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants