Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolve): ensure exports has precedence over mainFields (cherry pick #11234) #11595

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 5, 2023

Description

Fix #11114

This is a cherry-pick of #11234 which was previously reverted in #11270.

This removes an incorrect behaviour that's blocking correct exports of certain packages. This will fix the preact errors in ecosystem-ci and will bring an error in Histoire's CI, which we will investigate later on.

Additional context

More context in #11259 (comment)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p4-important Violate documented behavior or significantly improves performance (priority) label Jan 5, 2023
@bluwy bluwy added this to the 4.1 milestone Jan 5, 2023
@patak-dev patak-dev merged commit 691e432 into main Jan 5, 2023
@patak-dev patak-dev deleted the export-over-main-fields branch January 5, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module field takes precedence over exports in package.json
2 participants