Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove constructed sheet type style injection #11818

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

sapphi-red
Copy link
Member

Description

This PR removes the constructed sheet (adoptedStyleSheets) style-injection approach.

refs #11763

Additional context

I think we should merge this after 4.1.x is released in case #11763 causes a regression as this PR will create conflicts.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Jan 26, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me given the adoptedStylesheets limitation you noted:

adoptedStyleSheets are ordered after all the other style sheets.

@patak-dev patak-dev added this to the 4.2 milestone Feb 19, 2023
@bluwy bluwy merged commit 1a6a0c2 into vitejs:main Feb 22, 2023
@sapphi-red sapphi-red deleted the refactor/remove-construct-stylesheets branch February 24, 2023 12:54
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite change the style order in production that cause the overwrite issue
4 participants