Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pluginContainer): simplify error position judge condition #12003

Merged
merged 1 commit into from
Feb 11, 2023
Merged

chore(pluginContainer): simplify error position judge condition #12003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 2 additions & 7 deletions packages/vite/src/node/server/pluginContainer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,13 +385,8 @@ export async function createPluginContainer(
if (ctx._activeCode) {
err.pluginCode = ctx._activeCode

const pos =
position != null
? position
: err.pos != null
? err.pos
: // some rollup plugins, e.g. json, sets position instead of pos
(err as any).position
// some rollup plugins, e.g. json, sets err.position instead of err.pos
const pos = position ?? err.pos ?? (err as any).position

if (pos != null) {
let errLocation
Expand Down