docs: define no longer follows the esbuild rules #12156
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Vite 2.x,
config.define
is passed to esbuild to perform the replacement.vite/packages/vite/src/node/optimizer/index.ts
Lines 279 to 299 in d4886ea
For now,
config.define
is no longer passed to esbuild when performing optimization. The line this PR deleted is introduced in #5570. The reproduction that time works on Vite4 now.Made a new demo to confirm https://stackblitz.com/edit/vite-nitjua?file=package-lock.json,vite.config.js&file=main.js
Additional context
We should bring this back after #11151 landed.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).