Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground): typecheck #12339

Merged
merged 1 commit into from
Mar 8, 2023
Merged

fix(playground): typecheck #12339

merged 1 commit into from
Mar 8, 2023

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Mar 8, 2023

Description

pass type check error introduced in #12207.
CI is failed on HEAD for now https://github.com/vitejs/vite/actions/runs/4366725444/jobs/7637110095.
But it's weird in #12207 all the tests are passed, are there some flaw in the CI flow 🤔

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@fi3ework
Copy link
Member Author

fi3ework commented Mar 8, 2023

Not only type check, there's also 1 failed test case.


CI passed, why all CI failed in https://github.com/vitejs/vite/actions/runs/4366725444/jobs/7637110752 with following errors 😅

FAIL  playground/css/__tests__/no-css-minify/no-css-minify.spec.ts [ playground/css/__tests__/no-css-minify/no-css-minify.spec.ts ]
Error: [vite]: Rollup failed to resolve import "#alias" from "/home/runner/work/vite/vite/playground-temp/css/main.js".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
 ❯ Object.onwarn node_modules/.pnpm/rollup@3.18.0/node_modules/rollup/dist/es/shared/node-entry.js:24[95](https://github.com/vitejs/vite/actions/runs/4366725444/jobs/7637110752#step:14:96)0:13
 ❯ ModuleLoader.handleInvalidResolvedId node_modules/.pnpm/rollup@3.18.0/node_modules/rollup/dist/es/shared/node-entry.js:23632:26
 ❯ node_modules/.pnpm/rollup@3.18.0/node_modules/rollup/dist/es/shared/node-entry.js:23592:26

@fi3ework
Copy link
Member Author

fi3ework commented Mar 8, 2023

cc @patak-dev @bluwy The error might block other PR's CI. Could merge this early.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @fi3ework!

@patak-dev patak-dev merged commit 4433c30 into vitejs:main Mar 8, 2023
@bluwy
Copy link
Member

bluwy commented Mar 9, 2023

Thanks for fixing this! It sometimes happen because the old PR CI was ran against the old main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants