Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: don't share cacheDir among different configs #12625

Merged
merged 1 commit into from
Mar 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions playground/assets/vite.config-relative-base.js
Expand Up @@ -21,4 +21,5 @@ export default defineConfig({
testConfig: {
baseRoute: '/relative-base/',
},
cacheDir: 'node_modules/.vite-relative-base',
})
1 change: 1 addition & 0 deletions playground/assets/vite.config-runtime-base.js
Expand Up @@ -57,4 +57,5 @@ export default defineConfig({
}
},
},
cacheDir: 'node_modules/.vite-runtime-base',
})
1 change: 1 addition & 0 deletions playground/assets/vite.config-url-base.js
Expand Up @@ -21,4 +21,5 @@ export default defineConfig({
testConfig: {
baseRoute: '/url-base/',
},
cacheDir: 'node_modules/.vite-url-base',
})
1 change: 1 addition & 0 deletions playground/css/vite.config-no-css-minify.js
Expand Up @@ -9,4 +9,5 @@ export default defineConfig({
minify: true,
cssMinify: false,
},
cacheDir: 'node_modules/.vite-no-css-minify',
})
1 change: 1 addition & 0 deletions playground/css/vite.config-relative-base.js
Expand Up @@ -21,4 +21,5 @@ export default defineConfig({
testConfig: {
baseRoute: '/relative-base/',
},
cacheDir: 'node_modules/.vite-relative-base',
})
1 change: 1 addition & 0 deletions playground/lib/vite.dyimport.config.js
Expand Up @@ -11,4 +11,5 @@ export default defineConfig({
},
outDir: 'dist/lib',
},
cacheDir: 'node_modules/.vite-dyimport',
})
1 change: 1 addition & 0 deletions playground/lib/vite.nominify.config.js
Expand Up @@ -9,4 +9,5 @@ export default defineConfig({
outDir: 'dist/nominify',
},
plugins: [],
cacheDir: 'node_modules/.vite-nominify',
})
1 change: 1 addition & 0 deletions playground/preload/vite.config-preload-disabled.ts
Expand Up @@ -23,4 +23,5 @@ export default defineConfig({
},
modulePreload: false,
},
cacheDir: 'node_modules/.vite-preload-disabled',
})
1 change: 1 addition & 0 deletions playground/preload/vite.config-resolve-deps.ts
Expand Up @@ -38,4 +38,5 @@ export default defineConfig({
return { relative: true }
},
},
cacheDir: 'node_modules/.vite-resolve-deps',
})
1 change: 1 addition & 0 deletions playground/worker/vite.config-es.js
Expand Up @@ -44,4 +44,5 @@ export default vite.defineConfig({
},
},
],
cacheDir: 'node_modules/.vite-es',
})
1 change: 1 addition & 0 deletions playground/worker/vite.config-iife.js
Expand Up @@ -47,4 +47,5 @@ export default vite.defineConfig({
},
},
plugins: [workerPluginTestPlugin()],
cacheDir: 'node_modules/.vite-iife',
})
1 change: 1 addition & 0 deletions playground/worker/vite.config-relative-base.js
Expand Up @@ -46,4 +46,5 @@ export default vite.defineConfig({
},
},
],
cacheDir: 'node_modules/.vite-relative-base',
})
12 changes: 6 additions & 6 deletions playground/worker/vite.config-sourcemap.js
Expand Up @@ -12,10 +12,11 @@ export default (sourcemap) => {
sourcemap = true
}

const typeName =
typeof sourcemap === 'boolean' ? 'sourcemap' : 'sourcemap-' + sourcemap

return vite.defineConfig({
base: `/iife-${
typeof sourcemap === 'boolean' ? 'sourcemap' : 'sourcemap-' + sourcemap
}/`,
base: `/iife-${typeName}/`,
resolve: {
alias: {
'@': __dirname,
Expand All @@ -33,9 +34,7 @@ export default (sourcemap) => {
},
},
build: {
outDir: `dist/iife-${
typeof sourcemap === 'boolean' ? 'sourcemap' : 'sourcemap-' + sourcemap
}/`,
outDir: `dist/iife-${typeName}/`,
sourcemap: sourcemap,
rollupOptions: {
output: {
Expand All @@ -46,5 +45,6 @@ export default (sourcemap) => {
},
},
plugins: [workerPluginTestPlugin()],
cacheDir: `node_modules/.vite-sourcemap-${typeName}`,
})
}