Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssr): show ssr module loader error stack #12651

Merged
merged 6 commits into from Mar 31, 2023
Merged

fix(ssr): show ssr module loader error stack #12651

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90342d3
fix(ssr): show ssr module loader error stack
sun0day Mar 29, 2023
a17cf21
fix: ssrLoadModule importee
sun0day Mar 29, 2023
22d8596
refactor: catch error in ssrImport
sun0day Mar 30, 2023
59ff7ed
feat: add a counter to mark ssr load err imported times
sun0day Mar 30, 2023
11dd367
feat: use WeakMap to store importee
sun0day Mar 31, 2023
b3f45d0
refactor: always override importee
sun0day Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/vite/src/node/ssr/ssrModuleLoader.ts
View file
Open in desktop
Expand Up @@ -147,7 +147,10 @@ async function instantiateModule(
context,
urlStack,
fixStacktrace,
)
).catch((err) => {
err.importee = dep
throw err
})
bluwy marked this conversation as resolved.
Show resolved Hide resolved
if (pendingDeps.length === 1) {
pendingImports.delete(url)
} else {
Expand Down Expand Up @@ -212,7 +215,8 @@ async function instantiateModule(
server.config.logger.error(
colors.red(
`Error when evaluating SSR module ${url}:` +
(e.importee ? ` failed to import "${e.importee}"\n` : '\n'),
(e.importee ? ` failed to import "${e.importee}"` : '') +
`\n|- ${e.stack}\n`,
),
{
timestamp: true,
Expand All @@ -221,7 +225,6 @@ async function instantiateModule(
},
)

delete e.importee
bluwy marked this conversation as resolved.
Show resolved Hide resolved
throw e
}

Expand Down