Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): resolve at import from dependency basedir #12796

Merged
merged 1 commit into from Apr 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite/rollup.config.ts
Expand Up @@ -125,7 +125,7 @@ function createNodePlugins(
// bundling the `resolve` dep.
'postcss-import/index.js': {
src: 'const resolveId = require("./lib/resolve-id")',
replacement: 'const resolveId = undefined',
replacement: 'const resolveId = (id) => id',
},
}),

Expand Down
12 changes: 12 additions & 0 deletions packages/vite/src/node/plugins/css.ts
Expand Up @@ -929,6 +929,18 @@ async function compileCSS(
if (resolved) {
return path.resolve(resolved)
}

// postcss-import falls back to `resolve` dep if this is unresolved,
// but we've shimmed to remove the `resolve` dep to cut on bundle size.
// warn here to provide a better error message.
if (!path.isAbsolute(id)) {
config.logger.error(
colors.red(
`Unable to resolve \`@import "${id}"\` from ${basedir}`,
),
)
}

return id
},
nameLayer(index) {
Expand Down
9 changes: 4 additions & 5 deletions packages/vite/src/node/plugins/resolve.ts
Expand Up @@ -695,12 +695,11 @@ export function tryNodeResolve(
let basedir: string
if (dedupe?.includes(pkgId)) {
basedir = root
} else if (
importer &&
path.isAbsolute(importer) &&
fs.existsSync(cleanUrl(importer))
) {
} else if (importer && path.isAbsolute(importer)) {
basedir = path.dirname(importer)
if (!fs.existsSync(basedir)) {
basedir = root
}
} else {
basedir = root
}
Expand Down
4 changes: 4 additions & 0 deletions playground/css/__tests__/css.spec.ts
Expand Up @@ -297,6 +297,10 @@ test('@import dependency w/ sass export mapping', async () => {
expect(await getColor('.css-dep-exports-sass')).toBe('orange')
})

test('@import dependency that @import another dependency', async () => {
expect(await getColor('.css-proxy-dep')).toBe('purple')
})

test('@import dependency w/out package scss', async () => {
expect(await getColor('.sass-dep')).toBe('lavender')
})
Expand Down
3 changes: 3 additions & 0 deletions playground/css/css-proxy-dep-nested/index.css
@@ -0,0 +1,3 @@
.css-proxy-dep {
color: purple;
}
6 changes: 6 additions & 0 deletions playground/css/css-proxy-dep-nested/package.json
@@ -0,0 +1,6 @@
{
"name": "@vitejs/test-css-proxy-dep-nested",
"private": true,
"version": "1.0.0",
"style": "index.css"
}
1 change: 1 addition & 0 deletions playground/css/css-proxy-dep/index.css
@@ -0,0 +1 @@
@import '@vitejs/test-css-proxy-dep-nested';
9 changes: 9 additions & 0 deletions playground/css/css-proxy-dep/package.json
@@ -0,0 +1,9 @@
{
"name": "@vitejs/test-css-proxy-dep",
"private": true,
"version": "1.0.0",
"style": "index.css",
"dependencies": {
"@vitejs/test-css-proxy-dep-nested": "file:../css-proxy-dep-nested"
}
}
1 change: 1 addition & 0 deletions playground/css/dep.css
@@ -1,2 +1,3 @@
@import '@vitejs/test-css-dep';
@import '@vitejs/test-css-dep-exports';
@import '@vitejs/test-css-proxy-dep';
4 changes: 4 additions & 0 deletions playground/css/index.html
Expand Up @@ -140,6 +140,10 @@ <h1>CSS</h1>
@import dependency w/ sass export mapping: this should be orange
</p>

<p class="css-proxy-dep">
@import dependency that @import another dependency: this should be purple
</p>

<p class="dir-dep">PostCSS dir-dependency: this should be grey</p>
<p class="dir-dep-2">
PostCSS dir-dependency (file 2): this should be grey too
Expand Down
1 change: 1 addition & 0 deletions playground/css/package.json
Expand Up @@ -18,6 +18,7 @@
"@vitejs/test-css-dep": "link:./css-dep",
"@vitejs/test-css-dep-exports": "link:./css-dep-exports",
"@vitejs/test-css-js-dep": "file:./css-js-dep",
"@vitejs/test-css-proxy-dep": "file:./css-proxy-dep",
"fast-glob": "^3.2.12",
"less": "^4.1.3",
"postcss-nested": "^6.0.1",
Expand Down
24 changes: 24 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.