Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency open to v9 #12880

Closed
wants to merge 4 commits into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 17, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
open ^8.4.2 -> ^9.1.0 age adoption passing confidence

Release Notes

sindresorhus/open

v9.1.0

Compare Source

v9.0.0

Compare Source

Breaking
  • Require Node.js 14 7f5995e
  • This package is now pure ESM. Please read this.
    • Please don't open issues regarding ESM / CommonJS.
  • open.openApp is now a named import: import {openApp} from 'open'
  • open.apps is now a named import: import {apps} from 'open'
Improvements
  • Add the ability to open default browser and default browser in private mode (#​294) 3b79981

Configuration

πŸ“… Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@stackblitz
Copy link

stackblitz bot commented Apr 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Apr 17, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Apr 20, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

Comment on lines +130 to +135
// open includes a declation of `__dirname` variable
// this conflicts with cjsPatchPlugin
'open/index.js': {
src: 'const __dirname = path.dirname(fileURLToPath(import.meta.url));',
replacement: '',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the best way to fix this.

@bluwy
Copy link
Member

bluwy commented Apr 20, 2023

Interesting to see open v9 got larger in size πŸ€” https://packagephobia.com/result?p=open Seems to be caused by sindresorhus/open#294

@sapphi-red
Copy link
Member

Umm, it seems the size gets bigger around 40kB/100kB.

Without this PR

package size: 752.1 kB
unpacked size: 3.3 MB

With this PR

package size: 787.9 kB
unpacked size: 3.4 MB

@bluwy
Copy link
Member

bluwy commented Sep 15, 2023

Let's close this for now, and revisit it when needed.

@bluwy bluwy closed this Sep 15, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Sep 15, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 9.x releases. But if you manually upgrade to 9.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/open-9.x branch September 15, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants