fix(worker): prevent load vite client

[bluwy]

Description

fix #12970

Make sure __vite__injectQuery util does not bring in /@vite/client in worker file context. This PR makes __vite__injectQuery it's own virtual module to prevent it.

I also reverted the worker guards introduce in #9064 (Preserve for now to not break things as they could still be loaded by HMR code)

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the PR Title Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[patak-dev]

/ecosystem-ci run

[ArnaudBarre]

I don't know if this is genius or if this language has way to much meta programming 😄

[ArnaudBarre]

For info this is fixing only some of the cases. If a plugin adds HMR code to a file imported by a worker, this will still load the client

[patak-dev]

/ecosystem-ci run nuxt

[vite-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
nuxt	❌ failure

[patak-dev]

/ecosystem-ci run nuxt

[vite-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
nuxt	❌ failure

[patak-dev]

It seems the Nuxt issue is caused by this PR, it is working fine against main: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/4797522268/jobs/8534613140

@bluwy maybe this change is a bit big for a patch. We could merge #12988 to avoid the regression and then queue this PR for Vite 4.4 (and maybe we start it soon)

[bluwy]

Arnaud might be right that it's causing the failure in Nuxt. I think I'll revert that for now and preserve the extra guards.

[bluwy]

/ecosystem-ci run nuxt

[vite-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
nuxt	❌ failure

[bluwy]

Didn't notice the fail. I'm not really sure what's going on, but I'm fine merging #12988 first then revisiting this again.

[jamsinclair]

(As mentioned in issue) Inlining the function could help solve #11266. If we don't want to inline the function for all files – we could detect classic workers via the import suffixes.

e.g.

const importSuffixes = new URL(importer, 'http://vitejs.dev').searchParams
const isClassicWorker = importSuffixes.has('worker_type') && importSuffixes.has('type', 'classic')

if (isClassicWorker) {
   // Inlines the injectQuery function to the top of the worker file
   str().prepend(__vite__injectQuery.toString())
} else {
   // prepend import string
}

[bluwy]

Going to close this in favour of #14918. It will fix #11266 instead.

For #12970, I think I've come around that /@vite/client in workers could be something we can continue to pursue, especially if we were to support HMR in workers one day.