Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(importAnalysisBuild): support parsing '__VITE_PRELOAD__' #13023

Merged
merged 3 commits into from Apr 28, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 10 additions & 9 deletions packages/vite/src/node/plugins/importAnalysisBuild.ts
Expand Up @@ -10,6 +10,7 @@ import {
bareImportRE,
cleanUrl,
combineSourcemaps,
indexOfReg,
isDataUrl,
isExternalUrl,
isInNodeModules,
Expand All @@ -36,7 +37,7 @@ export const preloadMarker = `__VITE_PRELOAD__`
export const preloadBaseMarker = `__VITE_PRELOAD_BASE__`

export const preloadHelperId = '\0vite/preload-helper'
const preloadMarkerWithQuote = `"${preloadMarker}"` as const
const preloadMarkerWithQuote = new RegExp(`['"]${preloadMarker}['"]`)

const dynamicImportPrefixRE = /import\s*\(/

Expand Down Expand Up @@ -507,10 +508,10 @@ export function buildImportAnalysisPlugin(config: ResolvedConfig): Plugin {
addDeps(normalizedFile)
}

let markerStartPos = code.indexOf(preloadMarkerWithQuote, end)
let markerStartPos = indexOfReg(code, preloadMarkerWithQuote, end)
// fix issue #3051
if (markerStartPos === -1 && imports.length === 1) {
markerStartPos = code.indexOf(preloadMarkerWithQuote)
markerStartPos = indexOfReg(code, preloadMarkerWithQuote)
}

if (markerStartPos > 0) {
Expand Down Expand Up @@ -577,7 +578,7 @@ export function buildImportAnalysisPlugin(config: ResolvedConfig): Plugin {

s.update(
markerStartPos,
markerStartPos + preloadMarkerWithQuote.length,
markerStartPos + preloadMarker.length + 2,
`[${renderedDeps.join(',')}]`,
)
rewroteMarkerStartPos.add(markerStartPos)
Expand All @@ -587,19 +588,19 @@ export function buildImportAnalysisPlugin(config: ResolvedConfig): Plugin {

// there may still be markers due to inlined dynamic imports, remove
// all the markers regardless
let markerStartPos = code.indexOf(preloadMarkerWithQuote)
let markerStartPos = indexOfReg(code, preloadMarkerWithQuote)
while (markerStartPos >= 0) {
if (!rewroteMarkerStartPos.has(markerStartPos)) {
s.update(
markerStartPos,
markerStartPos + preloadMarkerWithQuote.length,
markerStartPos + preloadMarker.length + 2,
'void 0',
)
}

markerStartPos = code.indexOf(
markerStartPos = indexOfReg(
code,
preloadMarkerWithQuote,
markerStartPos + preloadMarkerWithQuote.length,
markerStartPos + preloadMarker.length + 2,
)
}

Expand Down
6 changes: 6 additions & 0 deletions packages/vite/src/node/utils.ts
Expand Up @@ -1214,3 +1214,9 @@ const escapeRegexRE = /[-/\\^$*+?.()|[\]{}]/g
export function escapeRegex(str: string): string {
return str.replace(escapeRegexRE, '\\$&')
}

export function indexOfReg(str: string, reg: RegExp, pos: number = 0): number {
const matcher = str.slice(pos).match(reg)

return matcher?.index !== undefined ? matcher.index + pos : -1
}
sun0day marked this conversation as resolved.
Show resolved Hide resolved