chore: upgrade rollup to 3.25.2

[sun0day]

Description

• Adjust rollup log API calls

• Adjust rollup error code

• Delay removing the independent inline entry chunk in MPA since rollup@3.25.1 would share entry chunks. ps: vite already contains the test cases in playground/html

  • fix index.html without JS breaks multi-page app setup linking to the same stylesheet #13436
  • refs Prevent empty chunks and thoroughly improve experimentalMinChunkSize rollup/rollup#4989
  • refs feat(html): Inline entry chunk into html when possible #4555

• fix Internal rollup crash when transform generates invalid js #13571

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the PR Title Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[sun0day]

It seems that rollup version upgrade logic didn't follow the semantic versioning. I was thinking whether vite should keep the rollup version in the published package the same as vite main branch's or use ~x.y.z at least. @patak-dev @bluwy @sapphi-red

[patak-dev]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
analogjs	✅ success
astro	❌ failure
histoire	❌ failure
iles	❌ failure
ladle	✅ success
laravel	✅ success
marko	✅ success
nuxt	✅ success
nx	✅ success
previewjs	✅ success
qwik	✅ success
rakkas	✅ success
sveltekit	✅ success
unocss	✅ success
vite-plugin-pwa	✅ success
vite-plugin-ssr	❌ failure
vite-plugin-react	✅ success
vite-plugin-react-pages	✅ success
vite-plugin-react-swc	✅ success
vite-plugin-svelte	❌ failure
vite-plugin-vue	✅ success
vite-setup-catalogue	✅ success
vitepress	✅ success
vitest	✅ success

[patak-dev]

It seems that rollup version upgrade logic didn't follow the semantic versioning. I was thinking whether vite should keep the rollup version in the published package the same as vite main branch's or use ~x.y.z at least. @patak-dev @bluwy @sapphi-red

For reference, we already did this for a while last year, after other type changes in a rollup minor brought issues downstream. Since it is rare, we ended up reverting with time so projects could use newer versions of rollup sooner. It is hard to know what is best here. I'm leaning towards keeping the current scheme, interested in others' opinions.

[bluwy]

Yeah I think it's probably fine to keep it as-is for now. We have close development with Rollup, so we can followup the type changes as needed.

The PR looks good though. Could you also update it to 3.25.2 to fix #13571? Also, when I run pnpm i locally, pnpm creates a new line at the end of pnpm-lock.yaml (pnpm 8.6.3), the PR doesn't seem to have that new line 🤔

[sun0day]

Not sure whether we should deal with non-(string|number)-type pluginCode and code.

[bluwy]

I think that's fine for now 👍

[patak-dev]

All failing CIs are also failing in main, except for vite-plugin-ssr. @brillout I think we should merge this PR and release a new beta so we give a week more to others to try it out. I'll do that now, would you check why updating rollup is affecting your tests?

[brillout]

@patak-dev Fix pushed on VPS's main branch.

But I get another error which seems unrelated to Rollup:

[stderr] failed to load config from boilerplates/boilerplate-react-ts/vite.config.ts
[stderr] error during build:
Error: The URL must be of scheme file at boilerplates/boilerplate-react-ts/vite.config.ts
    at loadConfigFromBundledFile (file:///home/runner/work/vite-plugin-ssr/vite-plugin-ssr/node_modules/.pnpm/vite@4.4.0-beta.3_@types+node@18.16.5/node_modules/vite/dist/node/chunks/dep-64acfab2.js:65812:19)

The error originates from:

// node_modules/vite/dist/node/chunks/dep-64acfab2.js:65812:19

  65798 async function loadConfigFromBundledFile(fileName, bundledCode, isESM) {                                                                                            
  65799     // for esm, before we can register loaders without requiring users to run node                                                                                  
  65800     // with --experimental-loader themselves, we have to do a hack here:                                                                                            
  65801     // convert to base64, load it with native Node ESM.                                                                                                             
  65802     if (isESM) {                                                                                                                                                    
  65803         try {                                                                                                                                                       
  65804             // Postfix the bundled code with a timestamp to avoid Node's ESM loader cache                                                                           
  65805             const configTimestamp = `${fileName}.timestamp:${Date.now()}-${Math.random()                                                                            
  65806                 .toString(16)                                                                                                                                       
  65807                 .slice(2)}`;                                                                                                                                        
  65808             return (await dynamicImport('data:text/javascript;base64,' +                                                                                            
  65809                 Buffer.from(`${bundledCode}\n//${configTimestamp}`).toString('base64'))).default;                                                                   
  65810         }                                                                                                                                                           
  65811         catch (e) {                                                                                                                                                 
  65812             throw new Error(`${e.message} at ${fileName}`);                                                                                                         
  65813         }                                                                                                                                                           
  65814     } 

Let me know if you want a reproduction for that one.

[patak-dev]

Yes, please create a new issue. We're trying to avoid the temporal bundled config file in 4.4

[brillout]

Done: #13631.