Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): close vite-error-overlay with Escape key #13795

Merged
merged 5 commits into from
Jul 13, 2023
Merged

feat(client): close vite-error-overlay with Escape key #13795

merged 5 commits into from
Jul 13, 2023

Commits on Jul 12, 2023

  1. feat(client): close vite-error-overlay with Escape key

    @chaejunlee
    chaejunlee committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    fd240ff View commit details
    Browse the repository at this point in the history

  2. fix(client): remove EventListener correctly

    @chaejunlee
    chaejunlee committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c441e68 View commit details
    Browse the repository at this point in the history

  3. test(html): add hmr overlay close behavior test

    @chaejunlee
    chaejunlee committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ff9395d View commit details
    Browse the repository at this point in the history

  4. fix(client): put close() back as the member function

    @chaejunlee
    chaejunlee committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    033aead View commit details
    Browse the repository at this point in the history

  5. fix: remove .bind(this)

    @chaejunlee
    chaejunlee committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d67a4ee View commit details
    Browse the repository at this point in the history