Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(optimizer): avoid double-commit of optimized deps when discovery is disabled #13865

Merged
merged 2 commits into from Jul 25, 2023
Merged

fix(optimizer): avoid double-commit of optimized deps when discovery is disabled #13865

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da6ba09
fix(optimizer): avoid race condition when discovery is disabled
kherock Jul 15, 2023
c41fab1
refactor: when discovery is disabled, bail during onCrawlEnd
kherock Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite/src/node/optimizer/optimizer.ts
View file
Open in desktop
Expand Up @@ -625,7 +625,7 @@ async function createDepsOptimizer(
// It normally should be over by the time crawling of user code ended
await depsOptimizer.scanProcessing

if (!isBuild && optimizationResult) {
if (!isBuild && optimizationResult && !config.optimizeDeps.noDiscovery) {
const result = await optimizationResult.result
optimizationResult = undefined
currentlyProcessing = false
Expand Down