docs(chunkSplitting): silence invalid config warning #13911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the consumer IS using a function form of manualChunks, this warning message is not needed. I believe it was incorrectly being displayed anyway because of the missing `else` block
|
|
ghost
changed the title
ghost
changed the title
|
Hi. We already have a PR at #13798. I forgot to follow-up on that and will merge that now. There's another improvement we can do noted at #13798 (comment) if you'd like to help out though. Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The splitVendorChunk plugin was displaying this warning even when the consumer vite.config
was using the function form of output.manualChunk
When the consumer IS using a function form of manualChunks, this warning message is not needed.
I believe it was incorrectly being displayed anyway because of the missing
elseblockAdditional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).