fix: avoid crawl end logic for ssr build #13976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bluwy
reviewed
Jul 29, 2023
| @@ -96,7 +96,7 @@ export function optimizedDepsBuildPlugin(config: ResolvedConfig): Plugin { | |||
|
|
|||
| if (depsOptimizer.isOptimizedDepFile(id)) { | |||
| return id | |||
| } else { | |||
| } else if (!options.ssr) { | |||
There was a problem hiding this comment.
I don't understand why we do it specifically for SSR? I ran the repro and the build seems to get stuck for me. I wonder if this could also be fixed by #13127? (I forgot about that PR but I think we could also merge that too)
There was a problem hiding this comment.
My wires crossed with SSR dev here, where we only optimize what is explicitly defined. Closing this PR. I need to finish the delayLoading feat for rollup. Closing this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We shouldn't be doing extra resolves when we are in build SSR. I found a
Unexpected early exit. This happens when Promises returned by plugins cannot resolve.when testing https://stackblitz.com/edit/github-vke2fz-bbe4ra?file=vite.config.ts&terminal=build locally and adding a local override to Vite. I don't know how to add a test for this one though.What is the purpose of this pull request?