Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add generic type for plugin api #14238

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Aug 30, 2023

Description

Wait for upstream PR rollup/rollup#5112 to be released.

  • Upgrade rollup
  • Add generic type to Plugin

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Aug 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sxzz sxzz marked this pull request as draft August 30, 2023 05:57
@sxzz sxzz marked this pull request as ready for review September 6, 2023 08:39
@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Sep 6, 2023

📝 Ran ecosystem CI: Open

suite result
analogjs ✅ success
astro ✅ success
histoire ❌ failure
ladle ❌ failure
laravel ✅ success
marko ✅ success
nuxt ❌ failure
nx ✅ success
previewjs ✅ success
qwik ✅ success
rakkas ✅ success
sveltekit ✅ success
unocss ❌ failure
vite-plugin-pwa ✅ success
vite-plugin-ssr ✅ success
vite-plugin-react ✅ success
vite-plugin-react-pages ❌ failure
vite-plugin-react-swc ✅ success
vite-plugin-svelte ❌ failure
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ❌ failure
vitest ❌ failure

@patak-dev
Copy link
Member

Probably a good idea to wait until ecosystem-ci is greener in main before merging this one. At least Nuxt and VitePress seem to be new fails. It could be that they aren't yet using rollup types from Vite. cc @dominikg

@sxzz
Copy link
Member Author

sxzz commented Sep 6, 2023

I think the stale Rollup version caused the errors. If upstreams use Vite 5, then they have to ensure the latest Rollup version (if installed)

@sxzz
Copy link
Member Author

sxzz commented Sep 6, 2023

After upgrading Rollup in Nuxt repo, I pass the ecosystem-ci test on my local machine.
image

bluwy
bluwy previously approved these changes Sep 8, 2023
@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Sep 10, 2023
@sapphi-red sapphi-red added this to the 5.0 milestone Sep 10, 2023
@sapphi-red sapphi-red merged commit 830b26e into vitejs:main Sep 18, 2023
11 checks passed
@sxzz sxzz deleted the feat/plugin-generic branch September 18, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants