Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifest): incorrect css entry files in manifest when falsy cssCodeSplit #14287

Closed
wants to merge 1 commit into from

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Sep 4, 2023

Description

fix #14271

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Sep 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@silverwind
Copy link

Maybe also fixes #14047?

@sun0day
Copy link
Member Author

sun0day commented Sep 5, 2023

Maybe also fixes #14047?

I am afraid that's a another problem. I will dig into it later.

@sapphi-red
Copy link
Member

Thanks for the PR. Closing as css entries doesn't make sense with cssCodeSplit: false (#14271 (comment)).

@sapphi-red sapphi-red closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect manifest entries for CSS entry points
3 participants