Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use Node 18.17 for Windows due to a bug in Node #14507

Merged
merged 1 commit into from
Sep 30, 2023
Merged

ci: use Node 18.17 for Windows due to a bug in Node #14507

merged 1 commit into from
Sep 30, 2023

Conversation

sapphi-red
Copy link
Member

Description

The Windows CI is failing due to nodejs/node#48673
This PR changes Windows CI to run on Node 18.17 instead of 18.18.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Sep 30, 2023
patak-dev
patak-dev approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main branch requires the new node_version now

@patak-dev patak-dev merged commit cb3ab5f into vitejs:main Sep 30, 2023
10 checks passed
@sapphi-red sapphi-red deleted the ci/use-node-18.17-for-windows branch September 30, 2023 07:30
bluwy pushed a commit that referenced this pull request Oct 3, 2023
@sapphi-red @bluwy
ci: use Node 18.17 for Windows due to a bug in Node (#14507)
cdf2632
sapphi-red added a commit to sapphi-red/vite that referenced this pull request Oct 11, 2023
@sapphi-red
ci: revert "ci: use Node 18.17 for Windows due to a bug in Node (vite…
e04669d 
…js#14507)"

This reverts commit cb3ab5f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sapphi-red @patak-dev