Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove jest condition #14544

Merged
merged 1 commit into from Oct 9, 2023
Merged

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Oct 6, 2023

Description

Since Vite have migrated to Vitest #8076 and removed Jest, so some conditions can be removed.

previously #8783

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sxzz sxzz mentioned this pull request Oct 6, 2023
9 tasks
@bluwy bluwy added feat: ssr breaking change p3-significant High priority enhancement (priority) labels Oct 6, 2023
@bluwy bluwy changed the title refactor: remove jest condition refactor!: remove jest condition Oct 6, 2023
@sapphi-red
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 9, 2023

📝 Ran ecosystem CI: Open

suite result
analogjs ✅ success
astro ✅ success
histoire ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt ✅ success
nx ✅ success
previewjs ✅ success
qwik ❌ failure
rakkas ✅ success
sveltekit ✅ success
unocss ✅ success
vike ✅ success
vite-plugin-pwa ✅ success
vite-plugin-react ✅ success
vite-plugin-react-pages ✅ success
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ❌ failure

@sapphi-red
Copy link
Member

#5197 adds it but it's not quite clear how to reproduce it today to see if it's fixed.

I guess jest wasn't working even with --experimental-vm-modules in #5197 because of a bug in jest. Also the segfault error should be fixed by Node 20.8.0.
https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V20.md#rework-of-memory-management-in-vm-apis-with-the-importmoduledynamically-option

@bluwy bluwy merged commit 8d18a91 into vitejs:main Oct 9, 2023
10 checks passed
@sxzz sxzz deleted the refactor/remove-jest branch October 9, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change feat: ssr p3-significant High priority enhancement (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants