refactor: simplify build optimizer node_env handling

[bluwy]

Description

We can workaround the change in optimizer/index.ts with define: { 'process.env.NODE_ENV': 'process.env.NODE_ENV' } instead. (esbuild example)

Also I'm not sure if the check was wrong. The comment mentioned lib builds but we were checking generic builds. I changed the condition to check lib builds instead (same as define.ts)

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[sapphi-red]

I read through #8606 and #8714. It looks good to me.
Do we have a test for preserving process.env in a optimizedDep somewhere?

[bluwy]

Hmm looks like we don't. All tests pass if I set it like this:

  const define = {
    'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV || config.mode),
  }

I suppose we don't have a lot of test for the build optimizer + lib mode. Let me try to add a test.

[patak-dev]

It seems the condition was wrong, this looks good to me too

[bluwy]

I tried to add a test (in main for testing) and it's not quite working for the build optimizer with lib mode I think. Getting strange errors:

trace

vite v5.0.0-beta.14 building for production...
Unexpected early exit. This happens when Promises returned by plugins cannot resolve. Unfinished hook action(s) on exit:
(vite:build-import-analysis) transform "/Users/bjorn/Work/oss/vite/playground/lib/src/build-optimize.js"
(commonjs--resolver) resolveId "@vitejs/test-pkg-with-process-node-env" "/Users/bjorn/Work/oss/vite/playground/lib/src/build-optimize.js"
(vite:optimized-deps-build) load "/Users/bjorn/Work/oss/vite/playground/lib/node_modules/.vite-build-optimize/deps_build-1b690276/@vitejs_test-pkg-with-process-node-env.js"
error during build:
Error: Unexpected early exit. This happens when Promises returned by plugins cannot resolve. Unfinished hook action(s) on exit:
(vite:build-import-analysis) transform "/Users/bjorn/Work/oss/vite/playground/lib/src/build-optimize.js"
(commonjs--resolver) resolveId "@vitejs/test-pkg-with-process-node-env" "/Users/bjorn/Work/oss/vite/playground/lib/src/build-optimize.js"
(vite:optimized-deps-build) load "/Users/bjorn/Work/oss/vite/playground/lib/node_modules/.vite-build-optimize/deps_build-1b690276/@vitejs_test-pkg-with-process-node-env.js"
    at process.handleBeforeExit (file:///Users/bjorn/Work/oss/vite/node_modules/.pnpm/rollup@4.2.0/node_modules/rollup/dist/es/shared/node-entry.js:18801:28)
    at Object.onceWrapper (node:events:628:26)
    at process.emit (node:events:513:28)
    at process.emit (/Users/bjorn/Work/oss/vite/node_modules/.pnpm/source-map-support@0.5.21/node_modules/source-map-support/source-map-support.js:516:21)
 ELIFECYCLE  Command failed with exit code 1.

I'll merge it in for now then.