Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): render correct asset url when CSS chunk name is nested #15154

Merged
merged 1 commit into from Nov 27, 2023
Merged

fix(css): render correct asset url when CSS chunk name is nested #15154

merged 1 commit into from Nov 27, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 27, 2023 •
edited

Description

When the CSS chunk is generated in a nested directory, the rendered asset URL was wrong when using relative base.

refs #14945
fixes #15141

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added feat: css p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Nov 27, 2023
@sapphi-red sapphi-red mentioned this pull request Nov 27, 2023
Closed
7 tasks
@patak-dev patak-dev merged commit ef403c0 into vitejs:main Nov 27, 2023
11 checks passed
@sapphi-red sapphi-red deleted the fix/css-nested-chunk-name-relative-base-asset branch November 27, 2023 13:58
@benmccann benmccann mentioned this pull request Nov 27, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
feat: css p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in CSS output location
3 participants
@sapphi-red @patak-dev @bluwy