Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary NODE_ENV override #15738

Merged
merged 1 commit into from Feb 12, 2024

Conversation

hi-ogawa
Copy link
Collaborator

@hi-ogawa hi-ogawa commented Jan 29, 2024

Description

I noticed that currently pnpm -C playground/optimize-deps build is failing potentially due to this NODE_ENV override. The playground tests seem to be passing locally without it, so I'm wondering if this trick might be obsolete now. (ref: #8218 (comment), #9058, #9066)

Adding console.log("[NODE_ENV]", process.env.NODE_ENV) in vite.config.js, this is how it looks:

$ pnpm test-build playground/optimize-deps 
...

stdout | file:/home/hiroshi/code/others/vite/playground-temp/optimize-deps/playground-temp/optimize-deps/vite.config.js:8:9
[NODE_ENV] production


$ pnpm test-serve playground/optimize-deps 
...

stdout | file:/home/hiroshi/code/others/vite/playground-temp/optimize-deps/playground-temp/optimize-deps/vite.config.js:8:9
[NODE_ENV] development

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Jan 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@hi-ogawa hi-ogawa changed the title test: remove obsolete NODE_ENV override test: remove unnecessary NODE_ENV override Jan 29, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review January 29, 2024 04:07
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks for checking this out @hi-ogawa!

@patak-dev patak-dev merged commit ea09185 into vitejs:main Feb 12, 2024
17 checks passed
@hi-ogawa hi-ogawa deleted the test-remove-reset-NODE_ENV branch February 12, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants