Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fsp.rm removing files does not take effect #16032

Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix: fsp.rm removing files does not take effect #16032

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9119176
fix: `fsp.rm` removing files does not take effect
btea Feb 26, 2024
875ab2d
chore: add comment
btea Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/vite/src/node/optimizer/index.ts
View file
Open in desktop
Expand Up @@ -502,9 +502,12 @@ export function runOptimizeDeps(
// No need to wait, we can clean up in the background because temp folders
// are unique per run
debug?.(colors.green(`removing cache dir ${processingCacheDir}`))
fsp.rm(processingCacheDir, { recursive: true, force: true }).catch(() => {
try {
// When exiting the process, `fsp.rm` may not take effect, so we use `fs.rmSync`
fs.rmSync(processingCacheDir, { recursive: true, force: true })
} catch (error) {
// Ignore errors
})
}
}
}

Expand Down