Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin): avoid duplicate import (#2640) #2897

Merged
merged 3 commits into from Apr 22, 2021
Merged

fix(plugin): avoid duplicate import (#2640) #2897

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
343b33c
fix(plugin): avoid duplicate import (#2640)
ygj6 Apr 7, 2021
ece0572
fix(plugin-vue): use Vite internal convention
ygj6 Apr 21, 2021
9433dcd
chore: fix spacing in import
patak-dev Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/plugin-vue/src/main.ts
View file
Open in desktop
Expand Up @@ -143,10 +143,10 @@ export async function transformMain(
// SSR module registration by wrapping user setup
if (ssr) {
output.push(
`import { useSSRContext } from 'vue'`,
`import { useSSRContext as _useSSRContext} from 'vue'`,
`const _sfc_setup = _sfc_main.setup`,
`_sfc_main.setup = (props, ctx) => {`,
` const ssrContext = useSSRContext()`,
` const ssrContext = _useSSRContext()`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should name it __vite_useSSRContext, it is the convention for Vite internal helpers used in other places.

Note: I think we could detect the presence of useSSRContext and only inserted when needed, but this PR fixes the issue at this point and we could improve things later.

` ;(ssrContext.modules || (ssrContext.modules = new Set())).add(${JSON.stringify(
filename
)})`,
Expand Down