fix: transform without sourcesContent

[wmzy]

Description

If we use a plugin with transform like:

import MagicString from 'magic-string';
import type { Plugin } from 'vite';

export default function testTransformPlugin(): Plugin {
  return {
    name: 'testTransform',
    async transform(code, id) {
      const magicString = new MagicString(code);
      magicString.prepend('/* todo */');

      return {
        code: magicString.toString(),
        map: magicString.generateMap(),
      };
    },
  };
}

The vite will be crashed when browser load a script like:

import 'react';

This is because the sourcemap of react has a virtual path:

{
  "version": 3,
  "sources": ["../object-assign/index.js", "../react/cjs/react.development.js", "../react/index.js", "dep:react"],
...
}

This PR has fixed the crash. But there is also a warn log.

Solution

I found that the pluginContainer.transform has not lost the sourcesContent which causes the injectSourcesContent to be called. And I fixed this.

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[aleclarson]

Can you provide a git repository that reproduces the bug that this PR is supposed to fix?

[wmzy]

@aleclarson just create by vite:

npm init vite@latest test-sourcemap -- --template react-ts

and replace vit.config.ts with:

import { defineConfig } from 'vite';
import MagicString from 'magic-string';

// https://vitejs.dev/config/
export default defineConfig({
  plugins: [{
    name: 'testTransform',
    async transform(code, id) {
      const magicString = new MagicString(code);
      magicString.prepend('/* todo */');

      return {
        code: magicString.toString(),
        map: magicString.generateMap(),
      };
    },
  }]
});

replace man.tsx with:

import 'react';

and then run:

vite

to start

[aleclarson]

@wmzy That does not reproduce the dep:react in sources scenario.

[wmzy]

test-sourcemap.zip
@aleclarson

[aleclarson]

@wmzy I'd prefer a git repository, or better instructions on how to reproduce manually.

[wmzy]

@aleclarson https://github.com/wmzy/test-sourcemap

This repository may be removed someday, please use the zip file if so.

[wmzy]

@aleclarson @patak-js Could you help to review and merge this pr?

The warn is noise and incorrect：

[aleclarson]

#5587 will fix this, I think

[patak-dev]

@wmzy is this still an issue with Vite 2.8?