Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CSS dependencies are tracked incorrectly when base is set #4592

Merged
merged 3 commits into from Aug 17, 2021
Merged

fix: CSS dependencies are tracked incorrectly when base is set #4592

merged 3 commits into from Aug 17, 2021

Commits on Aug 12, 2021

  1. fix: CSS dependencies are tracked incorrectly when base is set 

    The change in vitejs#4267 caused all CSS
dependencies of files that are not CSS (Tailwind CSS JIT deps) to be
tracked with the `base` prefix in the module graph.

URLs in the module graph are normalized and are never prefixed with base
and as a result changes to those files were not causing the CSS module
to be invalidated.

See tailwindlabs/tailwindcss#4978 (comment)
    @ElMassimo
    ElMassimo committed Aug 12, 2021
    Copy the full SHA
    23b4e88 View commit details
    Browse the repository at this point in the history

  2. test: hmr for non-css dependencies of css files

    @ElMassimo
    ElMassimo committed Aug 12, 2021
    Copy the full SHA
    c5c60d0 View commit details
    Browse the repository at this point in the history

  3. chore: avoid race condition in tests

    @ElMassimo
    ElMassimo committed Aug 12, 2021
    Copy the full SHA
    2cae360 View commit details
    Browse the repository at this point in the history