Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the base is duplicated in importAnalysisBuild.ts #4740

Merged
merged 2 commits into from Sep 13, 2021
Merged

fix: the base is duplicated in importAnalysisBuild.ts #4740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
873c84a
Fix a problem that the base is duplicated when importing css files dy…
hex-ci Aug 26, 2021
5f25f09
fix: dynamic import css test case
hex-ci Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/playground/dynamic-import/__tests__/dynamic-import.spec.ts
View file
Open in desktop
Expand Up @@ -50,8 +50,8 @@ test('should load dynamic import with vars', async () => {
test('should load dynamic import with css', async () => {
await page.click('.css')
await untilUpdated(
() => page.$eval('.css', (node) => window.getComputedStyle(node).boxSizing),
'border-box',
() => page.$eval('.view', (node) => window.getComputedStyle(node).color),
'rgb(255, 0, 0)',
true
)
})
2 changes: 1 addition & 1 deletion packages/vite/src/node/plugins/importAnalysisBuild.ts
View file
Open in desktop
Expand Up @@ -264,7 +264,7 @@ export function buildImportAnalysisPlugin(config: ResolvedConfig): Plugin {
const cssFiles = chunkToEmittedCssFileMap.get(chunk)
if (cssFiles && cssFiles.size > 0) {
cssFiles.forEach((file) => {
deps.add(config.base + file)
deps.add(file)
})
hasRemovedPureCssChunk = true
}
Expand Down