Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use debugger for package resolution warnings #4873

Merged
merged 2 commits into from
Sep 8, 2021
Merged

fix: use debugger for package resolution warnings #4873

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecf1101
Revert "chore: surface package resolution failures (#4822)"
antfu Sep 7, 2021
c938697
chore: add debugger
antfu Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/vite/src/node/ssr/ssrExternal.ts
View file
Open in desktop
Expand Up @@ -63,9 +63,6 @@ export function resolveSSRExternal(
requireEntry = require.resolve(id, { paths: [root] })
} catch (e) {
// resolve failed, assume include
config.logger.warn(
`Bundling package for SSR due to resolve failure. ${e.message}`
)
continue
}
if (!entry) {
Expand Down