Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid wrong warning of explicit public paths #4927

Merged
merged 1 commit into from Sep 14, 2021

Conversation

meteorlxy
Copy link
Contributor

Description

This issue is caused by #4631, reported here https://github.com/vitejs/vite/pull/4631/files#r707910410.

We should not simply determine publicPath by slicing the string, because the custom public dir can be outside the root dir.

It's OK to use startsWith to check if publicDir is inside root or not, because they are all resolved as absoluted path. An alternative way is to use path.relative().

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 9e06b81 into vitejs:main Sep 14, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants