Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return correct value when import css file with ?url #5229

Closed
wants to merge 2 commits into from
Closed

fix: return correct value when import css file with ?url #5229

wants to merge 2 commits into from

Conversation

CHOYSEN
Copy link
Contributor

@CHOYSEN CHOYSEN commented Oct 8, 2021

Description

fixes #5130

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

antfu
antfu previously approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if we could have a simple test for it

@CHOYSEN CHOYSEN force-pushed the fix/01 branch 3 times, most recently from e978512 to c37f16f Compare October 8, 2021 11:31
@CHOYSEN CHOYSEN closed this Oct 9, 2021
@jacksteamdev jacksteamdev mentioned this pull request Mar 15, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vite can not import css file as url
2 participants
@CHOYSEN @antfu