Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hmr): client pinging behind a proxy on websocket disconnect (fix #4501) #5466

Merged
merged 5 commits into from Mar 3, 2022
Merged

fix(hmr): client pinging behind a proxy on websocket disconnect (fix #4501) #5466

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d0d43d
fix pinging behind a proxy
mwarnerdotme Oct 28, 2021
c62cc4d
fix(hmr): client pinging behind a proxy on websocket disconnect
mwarnerdotme Oct 28, 2021
a53974f
Merge branch 'bug/4501-waitForSuccessfulPing' of github.com:mwarnerdo…
mwarnerdotme Oct 28, 2021
ad027a5
Merge branch 'main' into bug/4501-waitForSuccessfulPing
Shinigami92 Dec 30, 2021
d25a753
format
mwarnerdotme Dec 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/vite/src/client/client.ts
View file
Open in desktop
Expand Up @@ -208,9 +208,14 @@ async function waitForSuccessfulPing(ms = 1000) {
// eslint-disable-next-line no-constant-condition
while (true) {
try {
await fetch(`${base}__vite_ping`)
break
const pingResponse = await fetch(`${base}__vite_ping`)

// success - 2xx status code
if (pingResponse.ok) break
// failure - non-2xx status code
else throw new Error()
} catch (e) {
// wait ms before attempting to ping again
await new Promise((resolve) => setTimeout(resolve, ms))
}
}
Expand Down