Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop node v12 support #5843

Conversation

stygian-desolator
Copy link
Contributor

Description

close #5841

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added this to the 3.0 milestone Nov 26, 2021
@Shinigami92
Copy link
Member

Nice, we need to discuss if we want to have this PR open for the next half year or if we want maybe e.g. a 3.0-next target branch or somewhat.

@patak-dev
Copy link
Member

We have 115 PRs, we can keep it around until then 😅

@stygian-desolator
Copy link
Contributor Author

Haha, very much looking forward to the release of 3.0 😆

@Shinigami92
Copy link
Member

@stygian-desolator Could you rebase this PR? Than we can start to review it 🙂

@ydcjeff ydcjeff mentioned this pull request Apr 23, 2022
9 tasks
@bluwy
Copy link
Member

bluwy commented Apr 25, 2022

Closing as #7833 supersedes this, thanks for the contribution though!

@bluwy bluwy closed this Apr 25, 2022
@patak-dev patak-dev removed this from the 3.0 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

Drop Node v12 support
4 participants