Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base with relative path #6292

Closed
wants to merge 4 commits into from
Closed

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Dec 28, 2021

Description

fix #3650

Additional context

if config ./ will use relative path, but public asset will output in the root path.
output the relative path can't find the assets.

this pr make the relative path to the absolute path.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Mar 11, 2022
@poyoho poyoho closed this Apr 13, 2022
@poyoho poyoho deleted the fix/base-relative-path branch April 13, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL of public assets is wrong in built CSS files if assetsDir is set and base is './'
2 participants