Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent dev server crashing on malformed URI (fix #6300) #6308

Merged
merged 3 commits into from Dec 31, 2021
Merged

fix: prevent dev server crashing on malformed URI (fix #6300) #6308

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
776ebef
fix: prevent dev server crashing on malformed URI (fix #6300)
toSayNothing Dec 29, 2021
aa38327
chore: format
toSayNothing Dec 29, 2021
42a4fc7
fix: pass viteTransformMiddleware's decodeURI error to errorMiddleware
toSayNothing Dec 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/vite/src/node/server/middlewares/transform.ts
View file
Open in desktop
Expand Up @@ -99,10 +99,16 @@ export function transformMiddleware(
}
}

let url = decodeURI(removeTimestampQuery(req.url!)).replace(
NULL_BYTE_PLACEHOLDER,
'\0'
)
let url: string
try {
url = decodeURI(removeTimestampQuery(req.url!)).replace(
NULL_BYTE_PLACEHOLDER,
'\0'
)
} catch (e) {
res.end(`Bad request: ${e.message}`)
return
}

const withoutQuery = cleanUrl(url)

Expand Down