Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): wait on the socket host, not the ping host #6819

Merged
merged 1 commit into from May 10, 2022
Merged

fix(client): wait on the socket host, not the ping host #6819

merged 1 commit into from May 10, 2022

Commits on May 10, 2022

  1. fix(client): if the websocket fails to connect, wait on the socket ho… 

    …st, not the ping host

The problem with checking the ping host is that the ping host can
pass, even if the socket host fails, leading to infinite reloads.

Infinite reloads are a bad way to deal with this failure.
This makes the failure less bad.

For examples, see:
vitejs#6814
vitejs#3093
    @nicks
    nicks committed May 10, 2022
    Copy the full SHA
    ff67f09 View commit details
    Browse the repository at this point in the history